BBC: f0d0855037 broke B-Tag -- 7 years ago

For reasons I don't yet understand, when, yesterday, I tested a list of 600 or so CPAN distributions against perl-5.43.10 on both Linux and FreeBSD, B-Tap was one of the distros tested, even though it was not named in the list of modules passed to `cpan`. (It appears to have only one [reverse dependency](https://metacpan.org/dist/B-Tap/requires), which was not named in that list, either.) The distro failed on both platforms (*e.g.,* on [FreeBSD](https://www.cpantesters.org/cpan/report/7d0c9e08-3cb4-11f1-bf0d-d141eeb8f5ab)), which led me to take a look at its [CPANtesters results](http://fast2-matrix.cpantesters.org/?dist=B-Tap). I was surprised to see that it's been consistently failing since perl-5.32.0. On FreeBSD-14, where I test with threaded perls built with `clang` (currently 19.1.7), I bisected with this invocation: ``` perl Porting/bisect.pl \ --module=B::Tap \ --start=v5.28.0 \ --end=v5.32.0 ``` This pointed to v5.31.1-89-gf0d0855037: ``` f0d08550371fd1ddd8c85e309492802884a5a804 is the first bad commit commit f0d08550371fd1ddd8c85e309492802884a5a804 Author: David Mitchell <davem@iabyn.com> Date: Fri May 31 16:53:42 2019 +0100 Commit: David Mitchell <davem@iabyn.nospamdeletethisbit.com> CommitDate: Mon Jun 24 11:40:07 2019 +0100 make op.c:S_find_and_forget_pmops() non-recursive ... ``` @iabyn, can you take a look? Thank you very much.