[DRG] Wheeling Thrust and Fang & Claw are missing potency in some cases.
DRG skills don't track the 4th & 5th hit mechanic where the 5th hit of the combo will be +100 potency (effectively, 400 potency)
Current
```
skill_library.add_skill(
Skill(
name="Fang and Claw",
damage_spec={
SimConsts.DEFAULT_CONDITION: DamageSpec(potency=300),
"No Positional": DamageSpec(potency=260),
},
timing_spec=instant_gcd_timing_spec,
)
)
skill_library.add_skill(
Skill(
name="Wheeling Thrust",
damage_spec={
SimConsts.DEFAULT_CONDITION: DamageSpec(potency=300),
"No Positional": DamageSpec(potency=260),
},
timing_spec=instant_gcd_timing_spec,
)
)
```
Proposed (pseudo): Implemented via a combo.
```
skill_library.add_skill(
Skill(
name="Fang and Claw",
combo_spec=(ComboSpec(combo_actions=("Wheeling Thrust",)),),
damage_spec={
SimConsts.DEFAULT_CONDITION: DamageSpec(potency=400),
"No Positional": DamageSpec(potency=360),
"No Combo": DamageSpec(potency=300),
Utils.canonicalize_condition(
"No Combo, No Positional"
): DamageSpec(potency=260),
},
timing_spec=instant_gcd_timing_spec,
)
)
skill_library.add_skill(
Skill(
name="Wheeling Thrust",
combo_spec=(ComboSpec(combo_actions=("Fang and Claw",)),),
damage_spec={
SimConsts.DEFAULT_CONDITION: DamageSpec(potency=400),
"No Positional": DamageSpec(potency=360),
"No Combo": DamageSpec(potency=300),
Utils.canonicalize_condition(
"No Combo, No Positional"
): DamageSpec(potency=260),
},
timing_spec=instant_gcd_timing_spec,
)
)
```
关闭于 2024-02-19 1 条评论