ITADN

Unintentional Blocking of DeepL Translation Pop-up ( `deepl-inline-trigger` Tag) (example.com)

#4Closedrsuwa 创建于 2023-10-10
good first issuein progressincorrect blockinginformation required
R
rsuwacommented
### URL(s) where the issue occurs (mandatory) / 問題のURL(必須) <!-- (The issue title should be domain name of (one of) the URL; i.e. if the URL is "http://example.com/page.htm", take "example.com" without quotation as the title. If it's adult site, add [NSFW] in the head of the title.) --> <!-- (URLのドメイン名をIssueタイトルにしてください。http://example.com/page.htm であれば、example.comです。アダルトサイトの場合、[閲覧注意]か[NSFW]を先頭につけてください) --> <https://example.com/> Full URL / 完全なURL: <https://example.com/> ### Describe the issue (mandatory) / 何が問題か説明してください(必須) #### Problem: The current AdGuard Japanese filter Plus filter: ```css ##div[style*="z-index: 2147483647;"][style*="top: 0px; left: 0px;"][style*="position:"] ``` unintentionally hides elements utilized by the DeepL extension, impacting its functionality. Specifically, it interferes with elements enclosed in `<deepl-inline-trigger></deepl-inline-trigger>`, which use the same `z-index` style, making them disappear when the filter is applied. #### Impact: Users employing the DeepL extension for translation purposes may experience disruptive behavior and might be unable to use the extension effectively with the filter enabled. #### Proposed Solution: A refinement of the filter, aimed at specifically targeting the undesired elements while preserving those related to DeepL, has been experimented with and found effective in preliminary testing: ```css ##body > div[style*="z-index: 2147483647;"][style*="top: 0px; left: 0px;"][style*="position:"] ``` This selector employs the direct child combinator (`>`) to restrict the filter's effect to `div` elements directly under the `body` tag, potentially reducing unintentional hiding of nested DeepL elements. Further testing and validation across various websites and scenarios would be beneficial. ### Steps to Reproduce: 1. Install and enable the DeepL browser extension. - Firefox: https://addons.mozilla.org/en-US/firefox/addon/deepl-translate/ - Chromium: https://chrome.google.com/webstore/detail/deepl-translate-reading-w/cofdbpoegempjloogbagkncekinflcnj 3. Navigate to a webpage where you'd like to translate some text. 4. Select a text segment that you'd like to translate. 5. Notice that the DeepL pop-up (utilizing the deepl-inline-trigger tag) which should appear at the bottom right of the selected text is being blocked. ### Screenshot(s) / スクリーンショット <!-- (Replace %screenshot_url% with a link to the screenshot of the issue. You can drag & drop image instead.) --> <!-- (%screenshot_url%の部分をスクリーンショットのリンクに置き換えるか、そこのラインを消して画像ファイルをドラッグ&ドロップしてください) --> <details><summary>Correct behavior:</summary> ![image](https://i.gyazo.com/0a56d9ad1824a7c2da4eccfb75434dd7.gif) </details> <details><summary>Incorrect behavior:</summary> ![image](https://i.gyazo.com/eb0dc5729f1d2035d436669f6abe432a.gif) </details> ### Versions (mandatory) / バージョン情報(必須) - Operating system and version / OSの種類とバージョン: macOS Ventura 13.6 - Browser and version / ブラウザの種類とバージョン: Firefox 118.0.2 - AdGuard or uBlock Origin version / AdGuardないしuBlock Originのバージョン: uBlock Origin 1.52.2 ### Filters (mandatory) / 使用フィルタ(必須) <!-- (List all the filter lists you subscribe. You can take screenshot(s) of Filters (AdGuard)/Filter lists (uBlock) instead / 購読しているすべてのフィルタを記入するか、フィルター一覧のスクリーンショットを貼ってください) --> ``` listset (total-discarded, last-updated): added: https://abp.oisd.nl/: 206954-49818, 3h.5m https://get.letsblock.it/list/c6c363ab-28ec-4d56-aae3-dbcc8eed8d58.txt: 126-86, 3h.5m https://malware-filter.gitlab.io/pup-filter/pup-filter.txt: 189-0, 3h.5m https://raw.githubusercontent.com/DandelionSprout/adfilt/master/ClearURLs%20for%20uBo/clear_urls_uboified.txt: 712-8, 3h.5m https://raw.githubusercontent.com/DandelionSprout/adfilt/master/LegitimateURLShortener.txt: 2495-77, 3h.5m https://raw.githubusercontent.com/Yuki2718/adblock2/main/japanese/jpf-plus.txt: 760-32, never https://raw.githubusercontent.com/eEIi0A5L/adblock_filter/master/ichigo_filter.txt: 1588-65, 3h.5m https://raw.githubusercontent.com/eEIi0A5L/adblock_filter/master/kame_filter.txt: 153-0, 3h.5m https://raw.githubusercontent.com/quenhus/uBlock-Origin-dev-filter/main/dist/all_search_engines/global.txt: 7010-0, 3h.5m https://www.i-dont-care-about-cookies.eu/abp/: 25832-19, 3h.6m adguard-generic: 78392-6817, 3h.6m adguard-mobile: 8681-131, 3h.6m [21 lists not shown]: [too many] default: user-filters: 83-2, never ublock-filters: 35783-619, 3h.6m ublock-badware: 7213-9, 3h.6m ublock-privacy: 589-49, 3h.5m ublock-unbreak: 2185-2, 3h.6m ublock-quick-fixes: 188-0, 3h.5m easylist: 71651-1188, 3h.6m easyprivacy: 33224-930, 3h.6m urlhaus-1: 10910-0, 3h.5m plowe-0: 3719-32, 3h.6m JPN-1: 13522-102, 3h.6m ``` ### Notes / その他有用な情報
关闭于 2024-10-13 5 条评论