ITADN

location-conflation V3 handling

#12496Opentordans 创建于 2026-06-27
T
tordanscommented
This is getting a bit complex with multiple threads, so I try to collect the bits here The Bug we noticed: Fields appear twice https://github.com/openstreetmap/iD/issues/12491 * Why that happens: https://github.com/openstreetmap/iD/issues/12491#issuecomment-4800342779 When we [merged location-conflation v3](https://github.com/openstreetmap/iD/pull/12259), we added a check * @tyrasd added `+Q2` when missing https://github.com/openstreetmap/iD/blob/b9e7c5ee94d92b102c49230b8fa1db0a92660270/modules/services/nsi.js#L155C12-L161 However we removed that check [in a Refactor right after](https://github.com/openstreetmap/iD/pull/12349) * @bjornstar removed the `+Q2` at https://github.com/openstreetmap/iD/commit/17cf6ff15d49157643b629628796c4c587e86a17#diff-8cd3946f0d9504048c194412124882758cc9072b49e529b34e53898e7f6444cbL155-L161 --- Related is the idea that Kyle posted in https://github.com/rapideditor/location-conflation/pull/78 to give more visibility to this issue and make it easier to spot. --- We now have multiple ways to resolve this… **Fix in id-tagging-schema:** * Add the now required prop – https://github.com/openstreetmap/id-tagging-schema/pull/2381 ([Suggestion](https://github.com/openstreetmap/iD/issues/12491#issuecomment-4800447946)) * And make the field required in the schema ([Suggestion](https://github.com/openstreetmap/iD/issues/12491#issuecomment-4809315094)) **Fix in iD:** * See above; Reintroduce this workaround. **Fix in [Schema-Builder](https://github.com/ideditor/schema-builder):** * We keep the schema we have now and consider a missing `include` "Planet" and auto add it. --- My personal take is to pick the Schema-Builder solution because I find it too complex to explain in id-tagging-schema that an `exclude` requires and `include` (and I don't see the point in that to begin with) and we should just auto-add them so all consumers have the proper shape. We should ping other consumers, thought, to see if they can handle `Q2` or `Planet` given that we had [issues with `Q46` before](https://github.com/ideditor/schema-builder/issues/214) ([2](https://github.com/openstreetmap/id-tagging-schema/issues/1625)) – for GoMap [this was resolved](https://github.com/bryceco/GoMap/issues/855#issuecomment-3017190147) and `Q2` should IMO work.
1 条评论