Defining SynchedEntityData via BoatMixin causes issues with other mods' boats
bug
**Description of the Bug Encountered**
Wilder Wild defines a new type of SynchedEntityData for the vanilla Boat entity via mixin here:
https://github.com/FrozenBlock/WilderWild/blob/ba9172309ec6a26700c5b84eb45d2b0a95e5e77d/src/main/java/net/frozenblock/wilderwild/mixin/entity/penguin/BoatMixin.java#L43-L44
https://github.com/FrozenBlock/WilderWild/blob/ba9172309ec6a26700c5b84eb45d2b0a95e5e77d/src/main/java/net/frozenblock/wilderwild/mixin/entity/penguin/BoatMixin.java#L50-L53
This causes issues with other mods that do the same thing, or even just extend the Boat class for their own boat types, due to reasons detailed in https://github.com/FabricMC/fabric-api/issues/1049 and https://github.com/FabricMC/fabric-api/issues/3482
**Steps To Reproduce**
1. Install Wilder Wild and [Nature's Spirit](https://modrinth.com/mod/natures-spirit/version/TRMapjpU) v2.2.5 (the last version that extends vanilla's Boat class for its own boats)
2. Start the game, join a world, etc.
3. Place a boat from Nature's Spirit
4. The game crashes (if it doesn't, add some other mods; the crash is inconsistent)
**Expected Behavior**
No crash
**Screenshots**
N/A
**Logs**
Example with Nature's Spirit: https://gist.github.com/unilock/7c49bb6d9b8f82ca4adf7bae6479f3ca
**Additional context**
Same issue as https://github.com/FrozenBlock/WilderWild/issues/462 and https://github.com/FrozenBlock/WilderWild/issues/468, only with boat boosting instead of chest boat types this time
Perhaps Fabric's [Data Attachment API](https://docs.fabricmc.net/develop/data-attachments) could be used instead?
3 条评论