ITADN

macOS Sonoma Fixes

#166Pull Requestfurby-tm 创建于 2023-07-17
F
furby-tmcommented
Bit of a noisy commit, sorry about that. This repo should use a formatter, [SwiftFormat](https://github.com/nicklockwood/SwiftFormat) is a good one. It appears to be a SwiftUI bug, however applying a `.buttonStyle()` modifier, even with a `PlainButtonStyle()` appears to break the ability to click on any of the Server (AKA Guild) buttons -- at least on **macOS 14 Sonoma**. Not sure if it's functioning correctly on **macOS 13 Ventura** or below. In this revision I've removed the `.buttonStyle()` which introduces the default style -- _slightly ugly rounded rect button backgrounds_ to the buttons, however; it restores the functionality of these buttons in the meantime. The work for that can be summarized in the changes within the following files: - [ContentView](https://github.com/SwiftcordApp/Swiftcord/compare/main...furby-tm:Swiftcord:furby-server-buttons#diff-d131c5ff9849d610879359ab4078450ac5bf2c6941767871554822727dac393c) - [ServerButton](https://github.com/SwiftcordApp/Swiftcord/compare/main...furby-tm:Swiftcord:furby-server-buttons#diff-95c0dc20195420923f1a20a3ada5fa436c0d80a98ccb092cdb7360de0317239f) - [ServerFolder](https://github.com/SwiftcordApp/Swiftcord/compare/main...furby-tm:Swiftcord:furby-server-buttons#diff-ff19a8792edf304f104a2b59c0e2c68bf965c82ffb7c2fd452209019d3012750) There was also a fix for the settings window, as it does not open on versions **macOS 14 Sonoma** and above without being opened from within a `SettingsLink` closure. If server buttons are working as expected for older versions of macOS, I can clean these changes up and work out of a **macOS 14 Sonoma** branch which you can merge at some point down the line. Thanks! I appreciate your work so far on **Swiftcord**, the Swift community keeps getting more interesting by the day 😄.
合并状态:未合并 关闭于 2024-07-10 1 条评论