ITADN

Skip annotating invalid frames

#22Pull Requesteljamm 创建于 2025-06-15
E
eljammcommented
This is useful for stack traces that have more information than the `file:line count` format. For example, the [Nix language's evaluator profiler](https://github.com/NixOS/nix/pull/13220) also includes information about the function being called, which sometimes has a non-canonical call site location and therefore cannot be annotated. Here is how this might look like: ```log <nix/derivation-internal.nix>:37:12:primop derivationStrict ``` As such, with this change, we effectively skip annotating frames that don't conform to the `file:line count` format. ![image](https://github.com/user-attachments/assets/d96b4342-c543-4e1f-ad1d-cdc51b558e4c) Code portion from the [NGIpkgs overview](https://github.com/ngi-nix/ngipkgs/blob/4810584e62513da39b5cdee18ffb4aef4865a982/overview/default.nix#L238).
合并状态:未合并 2 条评论