`NS_ERROR_MALFORMED_URI` thrown when checking for out-of-scope URLs and `manifest.json` is undefined
Whenever I click an out-of-scope link in one of my PWAs it always opens a new window within the same PWA.
Digging a little deeper I found that the reason for this is that while checking if the current URL is out-of-scope the following line throws a NS_ERROR_MALFORMED_URI because `manifest.scope` is undefined:
https://github.com/filips123/PWAsForFirefox/blob/24a75cbc5cf037a3597952b28d3959f9746e6075/native/userchrome/profile/chrome/pwa/content/browser.sys.mjs#L2049
That seems like an edge-case that should be accounted for, specially considering that a few lines above the aforementioned we check the nullity of `manifest.scope`:
https://github.com/filips123/PWAsForFirefox/blob/24a75cbc5cf037a3597952b28d3959f9746e6075/native/userchrome/profile/chrome/pwa/content/browser.sys.mjs#L96
Thank you in advance.
3 条评论