[RFC] Removal of AflowPrototypeMatcher
`AflowPrototypeMatcher` uses the structure matcher to check against a list of prototypes from the first Aflow Prototype paper, there have since been two further updates with associated publications that are not covered. Given the existence of the functions added in #4329 that allow for generation of the prototype strings that would then enable string matching it seems reasonable to consider removing the older method that relies on the frozen json.gz.
Other options consist of adding more prototypes as addition json.gz or attempting to refactor the class such that it uses the prototype string methods implemented and then checks the `https://www.aflowlib.org/prototype-encyclopedia/<prototype_str>/` links for all the possible equivalent strings to check if something exists.
I probably favour removal and then adding a separate function to check if a prototype exists on the aflow site.
6 条评论