Incorrect formatter function call params?
I think there's a bug with `apheleia--run-formatter-function`. It is calling the format function with 2 `:callback` keyword args. Doesn't the second one override the first? This is trouble I think as the second value doesn't call the outer `callback` function, so it will never get informed of completion.
https://github.com/radian-software/apheleia/blob/main/apheleia-formatters.el#L1217
Context: I've been working on a custom formatter that extracts changed lines using vc and then calls clang-format with `--lines` to limit the formatting. This is working now when I just run thing sync. I tried to implement the same but with async using make-process which calls the callback when it completes and got really odd results.
0 条评论