ITADN

Release workflow uploads docker image as "result" instead of a proper filename

#5261Openpaolino 创建于 2026-04-20
P
paolinocommented
The draft release [v2026-04-17](https://github.com/cardano-foundation/cardano-wallet/releases/tag/untagged-b695c0f0b66358c02d5c) contains an asset whose **filename** is `result` (the Nix build symlink) instead of `cardano-wallet-v2026-04-17-docker-image.tgz`. The display label is correct, but the download filename is not. Asset details from the draft: - `name`: `result` - `label`: `cardano-wallet-v2026-04-17-docker-image.tgz` - `size`: ~276 MB - download URL: https://github.com/cardano-foundation/cardano-wallet/releases/download/untagged-b695c0f0b66358c02d5c/result ## Root cause [`.github/workflows/release.yml:358`](https://github.com/cardano-foundation/cardano-wallet/blob/master/.github/workflows/release.yml#L358): ```bash docker_file=$(find docker-image -type f | head -1) gh release upload "$TAG" "$docker_file#cardano-wallet-$TAG-docker-image.tgz" ``` The `#<label>` suffix on `gh release upload` sets only the display label — the uploaded asset name is still the source filename (`result`, from the Nix symlink). This also breaks [`.github/workflows/verify-release.yml`](https://github.com/cardano-foundation/cardano-wallet/blob/master/.github/workflows/verify-release.yml), which downloads by the pattern `cardano-wallet-${TAG}-docker-image.tgz` — it will not find the asset by that name. ## Suggested fix Rename (or copy) the file before uploading so the asset name matches the intended label: ```bash docker_file=$(find docker-image -type f | head -1) if [ -n "$docker_file" ]; then target="cardano-wallet-$TAG-docker-image.tgz" cp "$docker_file" "$target" gh release upload "$TAG" "$target" fi ``` ## Workaround for the current draft The `result` asset can be removed and re-uploaded manually (or the workflow re-run) before the release is published.
0 条评论