ITADN

Missing ScopeGuard in DHCP Client

#26713Openleegbestand 创建于 2026-04-11
L
leegbestandcommented
Hi, I was browsing through the DHCP service to understand it and noticed that it seems there is a `ScopeGuard` missing in the `set_params` function inside the `DHCPv4Client.cpp` file [link](https://github.com/SerenityOS/serenity/blob/3e0ef9397a1a9b3c32a0655543586ad43740dd96/Userland/Services/DHCPClient/DHCPv4Client.cpp#L83). Or is there a specific reason why the socket is not closed in that function? Thanks!
0 条评论