ITADN

Massive test fails due to fundamental change in `StateSpaceSet`

#398ClosedDatseris 创建于 2025-04-09
good first issuetests
D
Datseriscommented
Oh gods, there are countless of test failures. I think they are related with https://github.com/JuliaDynamics/StateSpaceSets.jl/pull/39 and in particular: - Fixed a critical bug where `eltype(ssset)` would return the element type of the stored points (e.g., `Float64`), instead of the type of the points themselves (e.g., `SVector{2, Float64}`). To be consistent with the Array interface and base Julia the correct return value is the type of the points themselves. Use `eltype(eltype(ssset))` to obtain the number type of the points. _Originally posted by @Datseris in https://github.com/JuliaDynamics/Associations.jl/issues/397#issuecomment-2786806367_ **Important notice**: the are many test failures, but all of them are related with exacrtly the same fix: change `eltype(ssset)` to `eltype(eltype(ssset))` in the source code. So it really is a simple fix, but one has to find all the places in the source code where this occurs. The test failure on current main branch can guide on this. (or run the tests locally)
关闭于 2025-04-11 2 条评论