Successful step function no longer works for parallel ODE system
good first issuetesting
Hm, some update in the OrdinaryDiffEq.jl library broke this. So, in the test suite for the `successful_step` function the parallel ODE fails to convey that the steps take have failed. Perhaps this is related to the fact that we pass in a custom norm `internalnorm = inorm` when we create a parallel ODE system, here
https://github.com/JuliaDynamics/DynamicalSystemsBase.jl/blob/89fcd8be5e878e2ac275274e3a27b378ff9780f3/src/derived_systems/parallel_systems.jl#L63
but honestly I am not sure. What I am sure about is that the test fails:
https://github.com/JuliaDynamics/DynamicalSystemsBase.jl/blob/89fcd8be5e878e2ac275274e3a27b378ff9780f3/test/successful_step.jl#L21
which is why in the current code this is commented out. We will need to test whether this is truly an OrdinaryDiffEq.jl problem by simply making a MWE with an `ODEProblem` with a parallel rule for two states and passing in a modified `internalnorm` as a keyword argument. If it is an OrdinaryDiffEq.jl problem, we open an issue there with our MWE. If not, then we have to fix it here.
0 条评论